Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.ansible-vim: init at 2.0 #53355

Merged
merged 1 commit into from Jan 4, 2019
Merged

vimPlugins.ansible-vim: init at 2.0 #53355

merged 1 commit into from Jan 4, 2019

Conversation

KAction
Copy link
Contributor

@KAction KAction commented Jan 3, 2019

  • [*] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • [*] other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [*] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [*] Tested execution of all binary files (usually in ./result/bin/)
  • [*] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [*] Assured whether relevant documentation is up to date
  • [*] Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title ###### Things done vimPlugins.ansible-vim: init at 2.0 Jan 3, 2019
Mic92
Mic92 reviewed Jan 3, 2019
View reviewed changes
pkgs/misc/vim-plugins/generated.nix
@@ -81,6 +81,17 @@ let
};
};

ansible-vim = buildVimPluginFrom2Nix {
Copy link
Member

@Mic92 Mic92 Jan 3, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should also commit your updated https://github.com/NixOS/nixpkgs/blob/41e373204912ba6d0b980212fbf1657ffbd321c0/pkgs/misc/vim-plugins/vim-plugin-names file

@KAction
Copy link
Contributor Author

KAction commented Jan 3, 2019

Okay. Force-pushed to my branch. Should I create new PR?

@Mic92 Mic92 merged commit 694ef93 into NixOS:master Jan 4, 2019
@KAction KAction deleted the ansible-vim=2.0 branch October 29, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KAction @Mic92 @timokau @GrahamcOfBorg