New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boehmgc: fix musl build #53364
boehmgc: fix musl build #53364
Conversation
tested with: `nix-build --arg crossSystem '(import ./lib).systems.examples.musl64' -A boehmgc`
Hmm. Things work here, though? On 8.0.2, but hmm.. Oh-- it applies and doesn't break, but the patch source is no longer available.... And you're saying we can just drop it because it's not needed? It does appear that's the case, let's do some builds to check.... |
(I suspect the risc-v patch isn't needed either; not sure how these weren't removed sorry!) |
@GrahamcOfBorg build pkgsMusl.boehmgc |
FWIW void still sets the flags in its build, should investigate which are and aren't needed... |
with the flags |
cc #53809 which was closed in recent commit (see the issue for reference), does that also fix the issue(s) motivating this/fixed here? |
The (exact same) patch can be downloaded from a previous git revision like this: (Note fetchpatch {
name = "boehm-gc-7.6.0-sys_select.patch";
url = "https://gitweb.gentoo.org/proj/musl.git/plain/dev-libs/boehm-gc/files/boehm-gc-7.6.0-sys_select.patch?id=85b6a600996bdd71162b357e9ba93d8559342432";
sha256 = "1gydwlklvci30f5dpp5ccw2p2qpph5y41r55wx9idamjlq66fbb3";
} Should we do this instead? |
Also it's fine with me closing this ticket now that ac7f4c0 is is |
Okay, thanks for the PR! Sorry for the run-around, but at least it should work now! :) |
The sys_select patch was removed and seems to no longer be applicable. Tested it builds with:
nix-build --arg crossSystem '(import ./lib).systems.examples.musl64' -A boehmgc
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)