Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boehmgc: fix musl build #53364

Closed
wants to merge 1 commit into from

Conversation

luigy
Copy link
Contributor

@luigy luigy commented Jan 4, 2019

The sys_select patch was removed and seems to no longer be applicable. Tested it builds with:
nix-build --arg crossSystem '(import ./lib).systems.examples.musl64' -A boehmgc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tested with:

`nix-build --arg crossSystem '(import ./lib).systems.examples.musl64' -A boehmgc`
@dtzWill
Copy link
Member

dtzWill commented Jan 4, 2019

Hmm. Things work here, though? On 8.0.2, but hmm..

Oh-- it applies and doesn't break, but the patch source is no longer available....

And you're saying we can just drop it because it's not needed? It does appear that's the case, let's do some builds to check....

@dtzWill
Copy link
Member

dtzWill commented Jan 4, 2019

(I suspect the risc-v patch isn't needed either; not sure how these weren't removed sorry!)

@dtzWill
Copy link
Member

dtzWill commented Jan 4, 2019

@GrahamcOfBorg build pkgsMusl.boehmgc

@dtzWill
Copy link
Member

dtzWill commented Jan 4, 2019

FWIW void still sets the flags in its build, should investigate which are and aren't needed...

@luigy
Copy link
Contributor Author

luigy commented Jan 4, 2019

with the flags configure couldn't find libatomic_ops so that may be in need of some tweaking

@dtzWill
Copy link
Member

dtzWill commented Jan 15, 2019

cc #53809 which was closed in recent commit (see the issue for reference), does that also fix the issue(s) motivating this/fixed here?

@dramforever
Copy link
Contributor

dramforever commented Jan 15, 2019

The (exact same) patch can be downloaded from a previous git revision like this: (Note ?id= in the URL)

fetchpatch {
  name = "boehm-gc-7.6.0-sys_select.patch";
  url = "https://gitweb.gentoo.org/proj/musl.git/plain/dev-libs/boehm-gc/files/boehm-gc-7.6.0-sys_select.patch?id=85b6a600996bdd71162b357e9ba93d8559342432";
  sha256 = "1gydwlklvci30f5dpp5ccw2p2qpph5y41r55wx9idamjlq66fbb3";
}

Should we do this instead?

@dramforever
Copy link
Contributor

Eh, that was exactly what happened in #53809

For reference: ac7f4c0

@luigy
Copy link
Contributor Author

luigy commented Jan 15, 2019

#53809 was the same thing I ran into. I ended up copying the derivation build from another store for the machine that hit this. The commit ac7f4c0 should also fix it for me, though the patch does not look necessary anymore but I have not verified it myself other than building it

@luigy
Copy link
Contributor Author

luigy commented Jan 15, 2019

Also it's fine with me closing this ticket now that ac7f4c0 is is master

@dtzWill
Copy link
Member

dtzWill commented Jan 15, 2019

Okay, thanks for the PR! Sorry for the run-around, but at least it should work now! :)

@dtzWill dtzWill closed this Jan 15, 2019
@luigy luigy deleted the boehmgc-fix-musl-build branch January 15, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants