Re-add security features based on GCC plugins in 4.18+ hardened kernels #53369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachifm
reviewed
Jan 4, 2019
|
I had no idea plugins had been disabled; I'd like to see them re-enabled unless there's a good reason not to. |
|
I disabled the above configs because there were build issues. It is possible they have been fixed in the meantime. Please do re-enable them, if all the kernels manage to build! |
|
@GrahamcOfBorg build linux_4_4.configfile linux_4_9.configfile linux_4_14.configfile linux_4_19.configfile linux_4_20.configfile linux_testing.configfile linux_hardened.configfile linux_latest_hardened.configfile linux_latest-libre.configfile |
|
@GrahamcOfBorg test kernel-lts kernel-latest |
delroth
referenced
this pull request
Jan 4, 2019
delroth
force-pushed
the
kernel-hardening
branch
from
639ccf2
to
0f7ca26
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
9236990 disabled GCC plugins in 4.18+ in NixOS hardened kernels. This is undesirable given that tons of nice PaX features are getting ported through these plugins -- for example, STACKLEAK in 4.20.
This PR attempts to re-enable plugins + adds STACKLEAK to the hardened config on 4.20+.
@joachifm @NeQuissimus
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)