Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bfs: 1.2.4 -> 1.3.1 #53377

Merged
merged 1 commit into from Jan 5, 2019
Merged

bfs: 1.2.4 -> 1.3.1 #53377

merged 1 commit into from Jan 5, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 4, 2019

Motivation for this change

disabled checkPhase because fails in sandboxed builds

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 4, 2019

@GrahamcOfBorg build bfs

@markuskowa markuskowa merged commit bdbf3f9 into NixOS:master Jan 5, 2019
@marsam marsam deleted the update-bfs branch January 6, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants