Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clickhouse: 18.14.18 -> 18.16.1 #53376

Merged
merged 2 commits into from Jan 7, 2019
Merged

clickhouse: 18.14.18 -> 18.16.1 #53376

merged 2 commits into from Jan 7, 2019

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jan 4, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/clickhouse/versions.

meta.description for clickhouse is: '"Column-oriented database management system"'.

Compare changes on GitHub

Checks done (click to expand)
  • built on NixOS
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-report had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-server had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-client had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-local had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-benchmark had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-performance-test had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-copier had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-extract-from-config had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-compressor had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-format had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-obfuscator had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-odbc-bridge had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-clang had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-lld had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-test had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-test-server had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/config-processor had a zero exit code or showed the expected version
  • /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/corrector_utf8 passed the binary check.
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse-zookeeper-cli had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin/clickhouse had a zero exit code or showed the expected version
  • 1 of 20 passed binary check by having a zero exit code.
  • 0 of 20 passed binary check by having the new version present in output.
  • found 18.16.1 with grep in /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1
  • directory tree listing: https://gist.github.com/8fe81858f80776fcafd68d7069935e75
  • du listing: https://gist.github.com/336aed21d03c63dffec1fc8584d91480
Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
clickhouse

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A clickhouse https://github.com/r-ryantm/nixpkgs/archive/9605c575a6d55d3dee28a0bf076e233ba7550c91.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1
ls -la /nix/store/yfmbsj89j46qg9128bkhjmb5bf916bxy-clickhouse-18.16.1/bin

cc @orivej for testing.

@r-ryantm
clickhouse: 18.14.18 -> 18.16.1
9605c57 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/clickhouse/versions
@Mic92
Copy link
Member

Mic92 commented Jan 4, 2019

@orivej the error I get looks fishy. Please have a look!

[nix-shell:~/.cache/nix-review/pr-53376]$ clickhouse
: CommandLine Error: Option 'x86-use-base-pointer' registered more than once!
LLVM ERROR: inconsistency in registered CommandLine options

@orivej-nixos orivej-nixos self-assigned this Jan 6, 2019
@orivej orivej mentioned this pull request Jan 6, 2019
Merged
@orivej
Copy link
Contributor

orivej commented Jan 6, 2019

Thanks for testing! (Since #52345 there is a NixOS module test too.) I have reported this upstream (ClickHouse/ClickHouse#3989) and copied the fix into this PR.

@orivej
clickhouse: link to libLLVM rather than to individual LLVM libs
e4e6955 
The clickhouse program links to LLVM and to the clickhouse library, that also
links to LLVM. When the library is shared but LLVM is static, LLVM gets linked
into the program twice (once via the library and once directly), which causes
this error when running clickhouse:

     : CommandLine Error: Option 'x86-use-base-pointer' registered more than once!
     LLVM ERROR: inconsistency in registered CommandLine options

A common LLVM installation provides static component libraries and a shared
libLLVM. Linking to libLLVM when libclickhouse is shared solves this issue.

Upstream pull request: ClickHouse/ClickHouse#3989
@orivej
Copy link
Contributor

orivej commented Jan 6, 2019

Upstream has merged my PR. Switched to fetchpatch here.

@orivej-nixos orivej-nixos merged commit fa17392 into NixOS:master Jan 7, 2019
@r-ryantm r-ryantm deleted the auto-update/clickhouse branch January 9, 2019 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@orivej-nixos orivej-nixos

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @Mic92 @orivej @GrahamcOfBorg @orivej-nixos