New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport nodejs from #53270 #53375
Merged
Merged
Backport nodejs from #53270 #53375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
requested review from
basvandijk,
edolstra,
edwtjo,
Ericson2314,
FRidh,
LnL7,
Mic92,
nbp,
peti,
Profpatsch,
ryantm,
rycee,
ttuegel and
zimbatm
as code owners
January 4, 2019 03:13
adisbladis
removed request for
zimbatm,
ryantm,
peti,
edwtjo,
Mic92,
ttuegel,
basvandijk,
LnL7,
rycee,
Ericson2314,
edolstra,
nbp,
FRidh and
Profpatsch
January 4, 2019 03:14
adisbladis
force-pushed
the
nodejs-backports
branch
from
January 4, 2019 03:15
53ce302
to
6e951d6
Compare
staging-18.09 maybe? |
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libuv/versions. (cherry picked from commit 5a95b0b)
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libuv/versions (cherry picked from commit ef93155)
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libuv/versions (cherry picked from commit 1699401)
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/http-parser/versions (cherry picked from commit 5b9ad12)
(cherry picked from commit 39bec39)
(cherry picked from commit bf84722)
(cherry picked from commit 4c917c6)
adisbladis
force-pushed
the
nodejs-backports
branch
from
January 10, 2019 11:36
6e951d6
to
3bd7f31
Compare
LGTM, I fixed the conflicts, any reason this is not merged into staging yet? |
GrahamcOfBorg
added
10.rebuild-darwin: 2501-5000
10.rebuild-linux: 5001+
and removed
2.status: merge conflict
labels
Feb 7, 2019
@wmertens No good reason except inertia. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backport nodejs changes from #53270.
Had to bump
libuv
to getnodejs-10-x
to build.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)