Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Visual Studio 2019 insists on upgrading the solution file #7135

Merged
merged 1 commit into from Jan 29, 2019

Conversation

nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Jan 29, 2019

Every time I build, Visual Studio 2019 clobbers my working copy with this change. Should probably integrate it.

Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did it before, that's why we had so many .sln

@orudge
Copy link
Contributor

orudge commented Jan 29, 2019

It should be safe to simply update the existing project file - when saving in 2017, it should (I think) preserve the higher version number. I'd need to verify that though...

Ideally of course we'd get that cmake migration done instead. :)

@nielsmh nielsmh merged commit 7c6e10d into OpenTTD:master Jan 29, 2019
@nielsmh nielsmh deleted the vs2019sln branch January 29, 2019 16:24
nielsmh added a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants