PICARD-1382: Fail macOS packaging scripts on error #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and not after successful build. That makes failing packaging also fail the build.
|
Builds failed successfully :D |
mineo
reviewed
Jan 29, 2019
| @@ -1,4 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
| set -e | |||
There was a problem hiding this comment.
Is the curl --upload-file "$dmg" https://transfer.sh/ code still used? If so, then this is not safe because curl returns an exit code of 0 for a lot of HTTP status codes a human might consider errors (401, 403, maybe even 502). It's possible to work around that by using --fail, but even that's not guaranteed to result in a non-zero exit code. To make that uploads with curl robust, you need `curl --write-out '%{http_code}' and check whatever that writes.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The packaging scripts for macOS currently do not fail on error but continue running and return with success.
Solution
Use
set -eto have the script terminate if any command fails.Action
Note: Expected result of this PR is that the build fails due to https://tickets.metabrainz.org/browse/PICARD-1456 . Actually a failing build indicates this PR is a success. If the build succeeds this PR is probably not working as expected ;)