Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: whitequark/libfx2
base: 158645a9267d
Choose a base ref
...
head repository: whitequark/libfx2
compare: 315dff8562fa
Choose a head ref
  • 3 commits
  • 10 files changed
  • 1 contributor

Commits on Jan 29, 2019

  1. Do not save/restore dpl/dph if it's used for passing parameters.

    See sdcc manual 4.1.5.2.
    whitequark committed Jan 29, 2019
    Copy the full SHA
    289fcd9 View commit details
    Browse the repository at this point in the history
  2. In fx2usbdfu and fx2usbmassstor, turn off overlay for setup handler.

    The setup handlers are leaf functions that are inferred to be non-
    reentrant, but this isn't actually safe. The memory for parameters
    (other than first) of non-reentrant functions is allocated in the OVR
    memory area, which means that it can be shared with other functions
    inferred as non-reentrant.
    
    This causes nasty race conditions that tend to crash the device.
    whitequark committed Jan 29, 2019
    Copy the full SHA
    ca0b81b View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    315dff8 View commit details
    Browse the repository at this point in the history