New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.scikit-build: init at 0.8.1 #54890
Conversation
You will need to patch the source to allow a more recent version of pytest-runner. |
80943df
to
ae1f3c1
Compare
I updated the expression, but the tests now triggers a bug in the way python3 is build at the moment. On an older NixOS system:
On the current unstable channel:
I will triage the source of the issue a bit longer, but it seems like |
That will be fixed by #54486. |
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/cannot-link-against-python/2054/2 |
So I guess we will have to wait for staging to be merged into master, before we can run these test again. Not to mention that I am still waiting to be added as a maintainer in a previous pull-request. |
You can also make your PR against staging. |
ae1f3c1
to
74251bc
Compare
@dotlambda: True, that is probably the easiest. Now with |
74251bc
to
55ab920
Compare
@GrahamcOfBorg build python2.pkgs.scikit-build python3.pkgs.scikit-build |
@GrahamcOfBorg build python2.pkgs.scikit-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, adding yourself to maintainer-list.nix
should be a separate commit.
f8475b3
to
f625b18
Compare
f625b18
to
c62202c
Compare
I split the commit in two and added the missing spelling correction. |
@FlorianFranzen Thank you for your patience! @GrahamcOfBorg build python2.pkgs.scikit-build |
@dotlambda No problem. I was the one who pushed a broken commit. The Python 3 builds are the most important ones, as the scikit-build testsuite will tell if Python's sysconfig is working (fixed by #54486, which was merged into unstable-next). |
Motivation
Tool to build easily build Python extensions with CMake.
Things done
Included patch was submitted upstream and is part of next release.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)