Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.scikit-build: init at 0.8.1 #54890

Merged
merged 2 commits into from Feb 14, 2019

Conversation

FlorianFranzen
Copy link
Contributor

@FlorianFranzen FlorianFranzen commented Jan 29, 2019

Motivation

Tool to build easily build Python extensions with CMake.

Things done

Included patch was submitted upstream and is part of next release.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

Could not find suitable distribution for Requirement.parse('pytest-runner<3dev,>=2.0')

You will need to patch the source to allow a more recent version of pytest-runner.

@dotlambda dotlambda changed the title pythonPackage.scikit-build: init of 0.8.1 pythonPackages.scikit-build: init at 0.8.1 Jan 29, 2019
@FlorianFranzen
Copy link
Contributor Author

I updated the expression, but the tests now triggers a bug in the way python3 is build at the moment.

On an older NixOS system:

$ python3 -c 'import sysconfig; print(sysconfig.get_config_var("INCLUDEPY"))' 
/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/include/python3.6m

On the current unstable channel:

$ nix-shell --pure -p python36 --run "python3 -c 'import sysconfig; print(sysconfig.get_config_var(\"INCLUDEPY\"))'"
/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-python3-3.6.8/include/python3.6m

I will triage the source of the issue a bit longer, but it seems like nuke-references breaks sysconfig at the moment.

@dotlambda
Copy link
Member

dotlambda commented Jan 30, 2019

That will be fixed by #54486.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/cannot-link-against-python/2054/2

@FlorianFranzen
Copy link
Contributor Author

So I guess we will have to wait for staging to be merged into master, before we can run these test again. Not to mention that I am still waiting to be added as a maintainer in a previous pull-request.

@dotlambda
Copy link
Member

You can also make your PR against staging.

@FlorianFranzen FlorianFranzen changed the base branch from master to staging-next February 14, 2019 14:17
@FlorianFranzen
Copy link
Contributor Author

@dotlambda: True, that is probably the easiest.

Now with staging-next as base and the missing maintainer entry.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.scikit-build python3.pkgs.scikit-build

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.scikit-build

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, adding yourself to maintainer-list.nix should be a separate commit.

@FlorianFranzen FlorianFranzen force-pushed the scikit-build branch 2 times, most recently from f8475b3 to f625b18 Compare February 14, 2019 19:45
@FlorianFranzen
Copy link
Contributor Author

FlorianFranzen commented Feb 14, 2019

I split the commit in two and added the missing spelling correction.

@dotlambda
Copy link
Member

@FlorianFranzen Thank you for your patience!

@GrahamcOfBorg build python2.pkgs.scikit-build

@dotlambda dotlambda merged commit f0edf20 into NixOS:staging-next Feb 14, 2019
@FlorianFranzen
Copy link
Contributor Author

FlorianFranzen commented Feb 14, 2019

@dotlambda No problem. I was the one who pushed a broken commit.

The Python 3 builds are the most important ones, as the scikit-build testsuite will tell if Python's sysconfig is working (fixed by #54486, which was merged into unstable-next).

@FlorianFranzen FlorianFranzen deleted the scikit-build branch March 12, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants