Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #318

Merged
merged 6 commits into from Feb 11, 2019
Merged

Upgrade dependencies #318

merged 6 commits into from Feb 11, 2019

Conversation

alastair
Copy link
Collaborator

This PR upgrades some dependencies indicated by github as having security updates, and also does a general python version upgrade (from pip list --outdated). I left some outdated packages at their normal version because these are dependencies of brainzutils, and should be updated there.

Some js dependencies of gulp have issues that can only be fixed by upgrading to gulp4. Doing this as a second step as it will probably require changes to the gulpfile too.

upgrades to python packages tested manually: flask-admin (go to admin), click (run commands), ndg-httpsclient (perform oauth login), pytest (run tests)

Now that we use docker, this script isn't needed for deployment
Remove explicit Werkzeug and click dependencies as these are added by
Flask
@alastair
Copy link
Collaborator Author

The new version of click has changed functions of the form init_db into init-db, causing tests to fail. Looking into it

From click 7, _ in function names are converted to -
(e.g. init_db -> init-db). In order to keep our configuration
and documentation up-to-date, specify command names manually
until we decide which format to use.
@alastair
Copy link
Collaborator Author

alastair commented Feb 4, 2019

@paramsingh this is working again, I updated manage.py to explicitly include the command names like you do in listenbrainz

Copy link
Collaborator

@paramsingh paramsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@alastair alastair merged commit 323378b into master Feb 11, 2019
@alastair
Copy link
Collaborator Author

Thanks, merged!

@alastair alastair deleted the upgrade-dependencies branch February 11, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants