Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mautrix-telegram: init at 0.4.0.post1 #54893

Merged
merged 5 commits into from Jan 31, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Jan 29, 2019

Motivation for this change

Bridge library between Matrix and Telegram

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.


let

localPython = python3.override {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't do that for python packages. However, isn't this an application rather than a library?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's both, because an other tool need to import it to work. What would be suggested to force the dependency version ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be suggested to force the dependency version ?

There is none as long as this is in pythonPackages. The suggested way to deal with this is to make an upstream PR that fixes it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you see in mautrix/telegram@a258c59, their pinning of telethon is completely useless. Just apply that patch to make it work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an other tool need to import it to work

Would you mind adding that tool to this PR or at least giving me a link?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the manual is suggesting that this is the preferred method when a python library is also a application

I'd say it's not actually a library, just a strange requirement of using alembic.
What's your stance @worldofpeace?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the manual is suggesting that this is the preferred method when a python library is also a application

I'd say it's not actually a library, just a strange requirement of using alembic.
What's your stance @worldofpeace?

I agree that this is an application and belongs in all-packages.nix and alembic just has this requirement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you ever need to use it with alembic you can use pkgs.python3.withPackages (ps: [ ps.alembic (ps.toPythonModule pkgs.mautrix-telegram) ]).

So they'd have to do that to setup the bridge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's only used for updating the database scheme.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be ok now

@nyanloutre nyanloutre force-pushed the mautrix-telegram branch 5 times, most recently from ddf463b to 1c2fe30 Compare January 29, 2019 23:57
@nyanloutre nyanloutre force-pushed the mautrix-telegram branch 2 times, most recently from ec0db1b to 4484a69 Compare January 30, 2019 09:55
@dotlambda dotlambda changed the title Mautrix telegram mautrix-telegram: init at 0.4.0.post1 Jan 30, 2019
@dotlambda
Copy link
Member

@GrahamcOfBorg build mautrix-telegram

@dotlambda dotlambda merged commit 864f832 into NixOS:master Jan 31, 2019
@nyanloutre nyanloutre deleted the mautrix-telegram branch January 31, 2019 13:03
@dotlambda
Copy link
Member

Seems like we forgot something: 6d19c1d

@dotlambda
Copy link
Member

and 467df7b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants