initrd: Fixed to include/use modprobe config files #54891
Conversation
|
Are there any updates on this pull request, please? |
|
I'm using it on my systems to load zfs with specific options since I've submitted it. A similar PR is opened in #64737, see #64737 (comment) for a comparison of both PRs. |
|
@aszlig You removed this config before. Is it okay to reintroduce? |
|
@JohnAZoidberg: Well, I removed it since it was breaking all VM tests, if this is no longer the case, I'm fine with it :-) |
The patch reintroduces modprobe nixos config that has been deactivate by 4a4c051. It has been removed since the firmware was included in the initrd (inflating it by more than 120M). The firmware is removed from the initrd closure.
dguibert
force-pushed
the
dg/initrd-modprobe-nixos-conf
branch
from
1763488
to
59489d7
Compare
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
Still using it to load zfs with specific options. |
stale
bot
removed
the
2.status: stale
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing since #145013 has been merged |
stale
bot
removed
the
2.status: stale
|
Closing since #145013 has been merged, as mentioned above. |
The patch reintroduces modprobe nixos config that has been deactivate by 4a4c051.
It has been removed since the firmware was included in the initrd
(inflating it by more than 120M). With this patch, the firmware is not added to the initrd closure but the modules are loaded with the same options as defined inside configuration.nix.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)