Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elixir: remember where a package is defined #54892

Merged
merged 1 commit into from Jan 29, 2019
Merged

elixir: remember where a package is defined #54892

merged 1 commit into from Jan 29, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Jan 29, 2019 •
edited

Motivation for this change

A bunch of human-facing things around Nixpkgs depend on knowing where a package was defined. This PR makes it so ofborg can ping elixir maintainers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member Author

grahamc commented Jan 29, 2019

also lol at not spelling elixir right.

@grahamc
elixir: remember where a package is defined
18993b3 
A bunch of human-facing things around Nixpkgs depend on knowing where
a package was defined. This PR makes it so ofborg can ping elixir
maintainers.
@grahamc grahamc changed the title elixer: remember where a package is defined elixir: remember where a package is defined Jan 29, 2019
@grahamc grahamc merged commit fb7ffda into NixOS:master Jan 29, 2019
@grahamc grahamc deleted the elixer-maintainer-ping branch January 29, 2019 17:54
@matthewbauer
Copy link
Member

Do you have the same issue with ghc / or anything else? Trying to see how extensive the issue is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grahamc @matthewbauer @GrahamcOfBorg