New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pulseaudio-dlna: downgrade dep zeroconf to 0.19.1 #54880
Conversation
The Python package zeroconf dropped support for Python 2 starting from version 0.20.0, so we need to use the previous version, 0.19.1, for pulseaudio-dlna. 0.19.1.nix was taken from 8655259 See: https://github.com/jstasiak/python-zeroconf#0200
@@ -30,7 +30,7 @@ pythonPackages.buildPythonApplication rec { | |||
|
|||
propagatedBuildInputs = with pythonPackages; [ | |||
dbus-python docopt requests setproctitle protobuf psutil futures | |||
chardet notify2 netifaces pyroute2 pygobject2 lxml zeroconf ] | |||
chardet notify2 netifaces pyroute2 pygobject2 lxml zeroconf_19 ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never put multiple versions of the same package in python-packages.nix
. Please use packageOverrides
inside the pulseaudio-dlna expression instead.
Also add a comment on why this is needed, maybe referencing masmu/pulseaudio-dlna#342.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll do as you said.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we could also use separate expression for Python 2 and 3, like
zeroconf = if isPy3k then callPackage ... else callPackage ...;
Upsteream actually started working on Python 3 support: masmu/pulseaudio-dlna#374 Maybe we could use that if it is stable enough. |
As per some helpful advice on IRC that I forgot who gave, we should probably wait for upstream to support Python 3 and update pulseaudio-dlna then. Closing it since I'm abandoning. |
Motivation for this change
The Python package zeroconf dropped support for Python 2 starting from
version 0.20.0, so we need to use the previous version, 0.19.1, for
pulseaudio-dlna.
0.19.1.nix was taken from 8655259
See: https://github.com/jstasiak/python-zeroconf#0200
On
nixpkgs-unstable
the derivation ofpulseaudio-dlna
fails to evaluate. Onnixos-18.09
it builds but non-fatally throws a exception on start. The exception does not seem to affect other functionalities.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)