Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strongswan: fix up path for modprobe #54029

Merged
merged 1 commit into from Jan 17, 2019
Merged

strongswan: fix up path for modprobe #54029

merged 1 commit into from Jan 17, 2019

Conversation

cdepillabout
Copy link
Member

strongswan uses modprobe to load IPSec-related kernel modules. The full path needs to be specified to modprobe for it to be able to be found.

Motivation for this change

strongswan is used by the l2tp plugin for NetworkManager, which I am using to connect to a VPN at work.

Without this change, strongswan produces the following error messages in the system log when enabling my VPN:

Jan 16 15:54:42 lemu8 NetworkManager[30106]: Starting strongSwan 5.7.1 IPsec [starter]...
Jan 16 15:54:42 lemu8 NetworkManager[30106]: Loading config setup
Jan 16 15:54:42 lemu8 NetworkManager[30106]: Loading conn '1c5abe1b-ebef-4658-8991-563d1d248812'
Jan 16 15:54:42 lemu8 ipsec_starter[30201]: Starting strongSwan 5.7.1 IPsec [starter]...
Jan 16 15:54:42 lemu8 ipsec_starter[30201]: Loading config setup
Jan 16 15:54:42 lemu8 ipsec_starter[30201]: Loading conn '1c5abe1b-ebef-4658-8991-563d1d248812'
Jan 16 15:54:42 lemu8 NetworkManager[30106]: sh: modprobe: command not found
Jan 16 15:54:42 lemu8 NetworkManager[30106]: sh: modprobe: command not found
Jan 16 15:54:42 lemu8 NetworkManager[30106]: sh: modprobe: command not found
Jan 16 15:54:42 lemu8 NetworkManager[30106]: sh: modprobe: command not found
Jan 16 15:54:42 lemu8 NetworkManager[30106]: sh: modprobe: command not found
Jan 16 15:54:42 lemu8 NetworkManager[30106]: found netkey IPsec stack
Jan 16 15:54:42 lemu8 ipsec_starter[30201]: found netkey IPsec stack
Jan 16 15:54:42 lemu8 ipsec_starter[30215]: Attempting to start charon...

The line in question is sh: modprobe: command not found. Note that this doesn't appear to cause any problem, but it is nice to not get these error messages in the log.

With this PR, strongswan doesn't produce the sh: modprobe: command not found lines.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
strongswan: fix up path for modprobe
2449f5c 
strongswan uses `modprobe` to load IPSec-related kernel modules.  The
full path needs to be specified to `modprobe` for it to be able to be
found.

(cherry picked from commit 7143062172f6bad877a87c8e239f2421e0a48e2d)
@fpletz fpletz merged commit 5197e18 into NixOS:master Jan 17, 2019
@cdepillabout cdepillabout deleted the strongswan-modprobe branch January 17, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning left review comments

@fpletz fpletz fpletz approved these changes

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cdepillabout @hedning @fpletz @jtojnar @GrahamcOfBorg