Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmtk: init at 3.3.1 #54016

Merged
merged 14 commits into from Feb 8, 2019
Merged

cmtk: init at 3.3.1 #54016

merged 14 commits into from Feb 8, 2019

Conversation

tbenst
Copy link
Contributor

@tbenst tbenst commented Jan 15, 2019

Motivation for this change

Adds package for computational morphometry of biomedical images.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

One question is on the licensing: Core CMTK code is licensed under the GPLv3 or later. Bundled libraries may use different license terms; see Licenses/ directory for details. The other licenses are here. Should I put licenses.gpl3 or something else..?

@tbenst
Copy link
Contributor Author

tbenst commented Jan 15, 2019

Oof, sorry for the messy commit history. Let me know if you prefer that I clean this up in some fashion?

@CMCDragonkai
Copy link
Member

Yep you got to rebase it all into 1 commit.

@matthewbauer matthewbauer merged commit 1cb81a6 into NixOS:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants