Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update seafile-shared hash #54017

Merged
merged 2 commits into from Jan 16, 2019
Merged

Update seafile-shared hash #54017

merged 2 commits into from Jan 16, 2019

Conversation

jonafato
Copy link
Contributor

Motivation for this change

seafile-client does not build successfully because of a hash mismatch in seafile-shared. The old hash appears to point to commit b7f2be78c1d979ff1242c3b65b41228e31427843 rather than ea8f5e2b45612d77fee9934f942d1d7d55560dad, which is the commit that the v6.2.10 tag currently references.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonafato
Copy link
Contributor Author

@dotlambda I'm guessing seafile's release tag was moved after the 6.2.9 -> 6.2.10 commit in nixpkgs.

@dotlambda
Copy link
Member

That's a shame. We should open an upstream issue to tell them that's not okay at all.

@dotlambda
Copy link
Member

Also. I'm stepping down as maintainer because I don't want to maintain software created by such incompetent people. I refrain from quoting the old Linus.

@jonafato
seafile-shared: update hash
37c1c42 
`seafile-client` does not build successfully because of a hash mismatch
in `seafile-shared`. The old hash appears to point to commit
`b7f2be78c1d979ff1242c3b65b41228e31427843` rather than
`ea8f5e2b45612d77fee9934f942d1d7d55560dad`, which is the commit that the
`v6.2.10` tag currently references.
seafile-client, libsearpc: remove dotlambda from maintainers
19d52f2 
I do not want to maintain the package for a software that changes the
commit a version tag refers to.
See 37c1c42.
@jonafato
Copy link
Contributor Author

That's a shame. We should open an upstream issue to tell them that's not okay at all.

Good point, done. If / once I get an answer there, I'll follow up with a description of why this was a bad thing and how it'll end with package managers dropping the package entirely if this is a common occurrence.

@dotlambda
Copy link
Member

Just checked in my RSS reader's cache and the entry used to be titled v6.2.10: Merge pull request #2157 from haiwen/update_version_to_6.2.10, which is not b7f2be78c1d979ff1242c3b65b41228e31427843 but also definitely not ea8f5e2b45612d77fee9934f942d1d7d55560dad. Weird.
What I can confirm is that the entry changed upon reloading the RSS feed.

@dotlambda dotlambda merged commit 368b72a into NixOS:master Jan 16, 2019
@jonafato jonafato deleted the fix-seafile-shared-version branch January 16, 2019 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonafato @dotlambda @GrahamcOfBorg