Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.jq: init at 0.1.6 #54014

Merged
merged 1 commit into from Jan 19, 2019
Merged

pythonPackages.jq: init at 0.1.6 #54014

merged 1 commit into from Jan 19, 2019

Conversation

benley
Copy link
Member

@benley benley commented Jan 15, 2019

Motivation for this change

Python bindings for jq. This requires patching setup.py to avoid it doing nasty things, so it makes sense to include in nixpkgs so others don't need to figure it out again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@benley benley requested a review from FRidh as a code owner January 15, 2019 22:57
@benley benley merged commit c7677d9 into NixOS:master Jan 19, 2019
@benley benley deleted the jq-py branch January 19, 2019 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benley @FRidh @worldofpeace @GrahamcOfBorg