New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin GSettings support #54007
Darwin GSettings support #54007
Conversation
Running dconf daemon on Darwin is probably not trivial since it requires DBus. We are probably better of relying on GNextstepSettingsBackend.
c866f31
to
f4436f6
Compare
For some reason, meson does not detect Darwin and passes |
002d796
to
b90278d
Compare
Both C and ObjC compilers used are
which causes |
b90278d
to
9b9ce21
Compare
9b9ce21
to
99b6b06
Compare
Opened an upstream issue with Meson: mesonbuild/meson#4784 |
@jtojnar it looks like ofborg Darwin build of |
8dea263
to
39d9c18
Compare
To support GNextstepSettingsBackend and Cocoa notifications, certain libraries need to be added on Darwin.
39d9c18
to
2f4e167
Compare
Are there any other dconf uses we need to get rid of? We can also make dconf an optional propagated input of glib to reduce duplication. |
In general, packages should not depend on dconf (unless they explicitly need libdconf for low-level access). Instead, they should pick up the dconf-based GSettings backend module from the environment (passed by I am not sure what duplication do you mean but dconf depends on glib so we definitely cannot propagate it from there. |
I think this broke glibmm on darwin: https://hydra.nixos.org/build/87684380 Complains about not finding a header file:
There's similar failures in other darwin derivations. Needed by inkscape: https://hydra.nixos.org/job/nixpkgs/trunk/unstable#tabs-constituents |
Yeah, glib does not build them on Darwin: https://gitlab.gnome.org/GNOME/glib/blob/be10f19752223f2607ba1fe00408c75920792aba/gio/meson.build#L412-429 It previously did build them because it detects Mac by the presence of Cocoa. Maybe we need to convince glibmm glibmm it is on Darwin in a same way? Or report a bug? |
Yeah, there are the same checks, we need cocoa in glibmm: |
Motivation for this change
See #53307
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)