Support for yosys' $anyconst and $anyseq cells #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
suggested changes
Jan 15, 2019
nmigen/hdl/ast.py
Outdated
|
|
||
|
|
||
| class AnyConst(AnyValue): | ||
| def __init__(self, shape): |
There was a problem hiding this comment.
This is a no-op--this class does not need the __init__ method. (Though, once you remove it, you should change src_loc_at above.)
nmigen/hdl/ast.py
Outdated
|
|
||
| class AnySeq(AnyValue): | ||
| def __init__(self, shape): | ||
| super().__init__(shape) |
whitequark
approved these changes
Jan 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 80.4% 80.08% -0.33%
==========================================
Files 19 19
Lines 2986 3018 +32
Branches 644 648 +4
==========================================
+ Hits 2401 2417 +16
- Misses 541 555 +14
- Partials 44 46 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnyConstandAnySeqcorrespond to to the$anyconstand$anyseqRTLIL cells. They are useful for formal verification to represent "any value that doesn't change", and "any value that can change to another arbitrary value each clock cycle" respectively.Usage is analogous to declaring a
ConstantorSignal: