Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncurses: 6.1-20181027 -> 6.1-20190112 #54042

Merged
merged 1 commit into from Jan 19, 2019
Merged

ncurses: 6.1-20181027 -> 6.1-20190112 #54042

merged 1 commit into from Jan 19, 2019

Conversation

voobscout
Copy link
Contributor

v6.1-20181027 url is 404.

Motivation for this change

The url for https://invisible-mirror.net/archives/ncurses/current/ncurses-6.1-20181027.tgz produces 404 and this particular version is now available only as a patchset from https://invisible-mirror.net/archives/ncurses/6.1/ncurses-6.1-20181027.patch.gz

Unless there is a hard requirement for 20181027, here's an update to current latest 6.1-20190112

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

in reference to my borked attempt #53942

@voobscout
ncurses: 6.1-20181027 -> 6.1-20190112
5d2d6a8 
v6.1-20181027 url is 404.
@worldofpeace worldofpeace mentioned this pull request Jan 19, 2019
Closed
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build ncurses

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 19, 2019
@FRidh FRidh merged commit 138720f into NixOS:staging Jan 19, 2019
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/detecting-outdated-urls-in-nixpkgs/1959/1

@FRidh
Copy link
Member

FRidh commented Jan 24, 2019 •
edited

In the future please use cherry-pick -x.

Discard that.

@voobscout voobscout deleted the ncurses-update branch January 24, 2019 12:56
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkennington wkennington Awaiting requested review from wkennington

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@voobscout @worldofpeace @nixos-discourse @FRidh @samueldr @GrahamcOfBorg