mailutils: use system-sendmail instead of sendmailPath #54049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will it work on non-systemd systems? |
|
@GrahamcOfBorg eval |
|
@grahamc |
system-sendmail allows all sendmail's to be auto-detected, including on non-NixOS systems. This is, to me, a better UX than having to manually override the sendmailPath argument. In exchange, it is a breach of retro-compatibility. Given right now I can't see any uses for sendmailPath other than what is supported by system-sendmail, I didn't keep it, but it'd be possible to allow sendmailPath to override the choice of sendmail from system-sendmail.
Ekleog
force-pushed
the
mailutils-system-sendmail
branch
from
16c4e34
to
a6abec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
system-sendmail allows all sendmail's to be auto-detected, including on
non-NixOS systems. This is, to me, a better UX than having to manually
override the sendmailPath argument.
In exchange, it is a breach of retro-compatibility. Given right now I
can't see any uses for sendmailPath other than what is supported by
system-sendmail, I didn't keep it, but it'd be possible to allow
sendmailPath to override the choice of sendmail from system-sendmail.
Fixes #40871
Built on NixOS.
cc @orivej @vrthra