Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pypy: Correct Python version in meta description #54015

Merged
merged 1 commit into from Jan 16, 2019
Merged

pypy: Correct Python version in meta description #54015

merged 1 commit into from Jan 16, 2019

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Jan 15, 2019

Motivation for this change

#53123 incorrectly unified the Python version in the description strings of pypy2 and pypy3. Make them distinct again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
    • No changes, since this only affects metadata.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andersk
pypy: Correct Python version in meta description
892e7b9 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk requested a review from FRidh as a code owner January 15, 2019 23:08
@FRidh FRidh merged commit 6282071 into NixOS:master Jan 16, 2019
@andersk andersk deleted the pypy-python-version branch December 10, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andersk @FRidh @GrahamcOfBorg