Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.faker: 1.0.1 -> 1.0.2 #54501

Merged
merged 1 commit into from Jan 24, 2019
Merged

pythonPackages.faker: 1.0.1 -> 1.0.2 #54501

merged 1 commit into from Jan 24, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jan 23, 2019

Fixes tests for at least Python 3.6

Motivation for this change

#54425 for testing todo.sr.ht.

nix-build -A python2Packages.faker -A python35Packages.fake -A python36Packages.faker -A python3Packages.faker

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu eadwu requested a review from FRidh as a code owner January 23, 2019 14:41
@eadwu eadwu mentioned this pull request Jan 23, 2019
Merged
10 tasks
@eadwu
pythonPackages.faker: 1.0.1 -> 1.0.2
4ecd09e 
Fixes tests for at least Python 3.6
@Mic92 Mic92 merged commit 6b82289 into NixOS:master Jan 24, 2019
@eadwu eadwu deleted the pythonPackages.faker/1.0.2 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eadwu @dotlambda @Mic92 @GrahamcOfBorg