Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-generate-config: Include extraGroups "wheel" #54519

Merged
merged 1 commit into from Jan 27, 2019
Merged

nixos-generate-config: Include extraGroups "wheel" #54519

merged 1 commit into from Jan 27, 2019

Conversation

devhell
Copy link
Contributor

@devhell devhell commented Jan 23, 2019

Motivation for this change

I've been asked, on numerous occasions, by my students and others, how
to 'sudo' on NixOS.

Of course new users could read up in the manual on how to do that, or we
could make it more accessible for them by simply making it visible in
the default configuration.nix file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danbst
Copy link
Contributor

danbst commented Jan 23, 2019

It doesn't sound good to allow guest user sudo access xD. Maybe rename example user (anything except root and guest)?

@grahamc
Copy link
Member

grahamc commented Jan 24, 2019

Nice catch, @danbst.

@devhell
Copy link
Contributor Author

devhell commented Jan 24, 2019

Sooooo, what name shall we use instead? Off the top of my head maybe alice?

@infinisil
Copy link
Member

infinisil commented Jan 24, 2019 •
edited

How about john (from John Doe)

Edit: Or the female version jane (I like jane better). But alice would be fine too, feel free to choose yourself :)

@devhell
Copy link
Contributor Author

devhell commented Jan 26, 2019

Good auggestion. I think janedoe is my preference, since it might be more recognizable to those who aren't acquainted with 'alice'. I'll update the PR soon. Thanks!

@devhell
Copy link
Contributor Author

devhell commented Jan 27, 2019

I've updated the PR. :)

@infinisil
Copy link
Member

Oh, I thought just jane, janedoe is a bit weird as a username

@devhell
nixos-generate-config: Include extraGroups "wheel"
c3d22fd 
I've been asked, on numerous occasions, by my students and others, how
to 'sudo' on NixOS.

Of course new users could read up in the manual on how to do that, or we
could make it more accessible for them by simply making it visible in
the default `configuration.nix` file.

Additionally, as raised in [1], replacing `guest` with something more
recognizable could be potentially beneficial to new users. I've
opted for `jane` for now.

[1]: NixOS#54519 (comment)
@devhell
Copy link
Contributor Author

devhell commented Jan 27, 2019

Duh! @infinisil you're quite right. I brainfarted there, sorry. Updated.

@grahamc grahamc merged commit 18119f2 into NixOS:master Jan 27, 2019
@grahamc
Copy link
Member

grahamc commented Jan 27, 2019

Great PR :)

@devhell devhell deleted the modify_ngc.pl branch January 28, 2019 08:13
@devhell
Copy link
Contributor Author

devhell commented Jan 28, 2019

Thanks @grahamc, you're very kind. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@devhell @danbst @grahamc @infinisil @GrahamcOfBorg