[18.09] firefox 65 #54505
Merged
[18.09] firefox 65 #54505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 70b8ab6)
(cherry picked from commit fdc6caf)
This removes the 1.29 backport and replaces it with the 1.31 version from master.
jemalloc with stripped prefix would cause segfaults in free: NixOS#49557 (comment) This commit has been adjusted from the one on master to only carry the relevant changes (the new optional `stripPrefix`) flag while still keeping the other flags that were removed on master since they are no loner supported by the version used there. (cherry picked from commit 973eca7)
Firefox >=65 will depend on icu >=63. All the older firefox versions (and derived packages) seem to work fine with this change. Also the system path environment patch will fail to apply since there was a trivial whitespace change in the source file. By adding `-l` to patch we can avoid having to track two patches that do basically the same. Having patchFlags per file without resorting to pre-/postPatch would be nicer but there doesn't seem to be a facility for that right now. (cherry picked from commit e37b765e7897c015153552d4e33a8571ab9c5457)
vcunat
approved these changes
Jan 23, 2019
andir
force-pushed
the
18.09/firefox65
branch
from
052bed9
to
e76e890
Compare
|
It seems that Firefox65 will require an additional NSS version bump. The version isn't released yet thought :/ https://hg.mozilla.org/mozilla-unified/rev/3c3a040d5e3f So much for trying to prepare for a release ahead of time... |
|
Well, |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the stable counterpart to #54504. It is a bit more intrusive and therefore targeted towards staging-18.09.
I had to bump the usual suspects (
nss,rust) and a newcomer(?) icu in order to make Firefox happy with the system libraries we are providing.The rust upgrade is just importing the current version of rust 1.31 from stable into the tree. It replaces the previously backported version 1.29. All the previous versions of Firefox (and derived packages) build fine using the bumped versions.
The latest / last commit in this branch (052bed9) should be dropped before this is being merged.
This PR just serves the purpose of putting the changes out there and collect some initial feedback on the approach I took here.
I rebuild all the Firefox packages and executed the nixos tests for firefox. No unexpected failures.
If the general feedback is positive we should merge this into staging-18.09 before 2019-01-29 to be able to build the upcoming release version on 18.09.
cc'ing the release managers @vcunat @samueldr
and @taku0
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)