Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/restic: change type of timerConfig option #54514

Merged
merged 1 commit into from Jan 23, 2019
Merged

nixos/restic: change type of timerConfig option #54514

merged 1 commit into from Jan 23, 2019

Conversation

leotaku
Copy link
Contributor

@leotaku leotaku commented Jan 23, 2019

This is needed for correctly passing the option to "systemd.timer"

Motivation for this change

The restic module currently uses attrsOf type.str as the type for its timerConfig option. However the underlying systemd.timers uses the more complex unitOption type which allows for a more nuanced configuration of the timer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This is needed for correctly passing the option to "systemd.timer"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants