Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scons: update 3.0.4 hash #54511

Closed
wants to merge 1 commit into from
Closed

scons: update 3.0.4 hash #54511

wants to merge 1 commit into from

Conversation

dylex
Copy link
Contributor

@dylex dylex commented Jan 23, 2019

It appears that they updated their 3.0.4 distribution in-place with some additional patches:

SCons/scons@73b2c02

The changes are mainly cosmetic, so should be fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dylex
scons: update 3.0.4 hash
b9bd574 
Package was refreshed with some last-minute patches
@dylex
Copy link
Contributor Author

dylex commented Jan 23, 2019

Was just released #54461

@etu
Copy link
Contributor

etu commented Jan 24, 2019

@GrahamcOfBorg build scons

@primeos
Copy link
Member

primeos commented Jan 24, 2019

Just noticed this, already pushed this fix in f561acc. Feel free to ping me next time, maybe I would have noticed it in time ;)

@primeos primeos closed this Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dylex @etu @primeos @GrahamcOfBorg