fakeroot: Add sed dependency. #52846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasendubi
reviewed
Dec 25, 2018
| @@ -39,6 +39,9 @@ stdenv.mkDerivation rec { | |||
| done | |||
| ''; | |||
|
|
|||
| postInstall = '' | |||
| sed -i -e "s#for dir in \`echo \$PATHS | sed 's/:/ /g'\`#for dir in \`echo \$PATHS | ${gnused}/bin/sed 's/:/ /g'\`#" $out/bin/fakeroot | |||
There was a problem hiding this comment.
You could use a shorter.
sed -i -e "s#\<sed\>#${gnused}/bin/sed#g" $out/bin/fakeroot
Or you could even move it to postUnpack:
sed -i "s@sed@$(type -p sed)@g" ${name}/scripts/fakeroot.in
There was a problem hiding this comment.
I adopted the last solution. fakeroot.in seems much easier to patch, thanks for the suggestion.
Also I merged it with the @getopt@ patching, which had a weird no-op-ish for loop around it, which I removed.
rasendubi
approved these changes
Jan 4, 2019
|
@GrahamcOfBorg build autofs5 fakeroot hylafaxplus sssd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
If fakeroot is used in a build script, fakeroot fails to do its job.
Things done
Hardcode dependency.
Run resulting "fakeroot"
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)