Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snscrape: init at 0.1.3 #52758

Merged
merged 1 commit into from Dec 24, 2018
Merged

snscrape: init at 0.1.3 #52758

merged 1 commit into from Dec 24, 2018

Conversation

ivan
Copy link
Member

@ivan ivan commented Dec 24, 2018 •
edited

Motivation for this change

snscrape is a social networking service scraper that discovers URLs on Twitter, Instagram, Google Plus, and Facebook.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I manually tested that this works:

snscrape twitter-user patio11

@ivan ivan requested a review from FRidh as a code owner December 24, 2018 08:52
@ivan
Copy link
Member Author

ivan commented Dec 24, 2018

Updated to test that snscrape --help works.

dotlambda
dotlambda requested changes Dec 24, 2018
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/snscrape/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/snscrape/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/snscrape/default.nix Outdated Show resolved Hide resolved
@ivan
Copy link
Member Author

ivan commented Dec 24, 2018

Thanks for the review! I think I fixed everything you mentioned.

@dotlambda
Copy link
Member

@GrahamcOfBorg build snscrape

@dotlambda
Copy link
Member

Btw, putting this into pythonPackages is only allowed because "it is also possible to use snscrape as a library in Python": https://github.com/JustAnotherArchivist/snscrape#usage

@dotlambda dotlambda merged commit 82470c2 into NixOS:master Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan @dotlambda @GrahamcOfBorg