Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 11.5.4 -> 11.5.5 (CVE-2018-20229) #52748

Merged
merged 2 commits into from Dec 25, 2018
Merged

gitlab: 11.5.4 -> 11.5.5 (CVE-2018-20229) #52748

merged 2 commits into from Dec 25, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 24, 2018

Motivation for this change

This bumps gitlab from 11.5.4 to 11.5.5, fixing CVE-2018-20229

Needs backport to 18.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 24, 2018
@flokli flokli mentioned this pull request Dec 24, 2018
Merged
10 tasks
@flokli
Copy link
Contributor Author

flokli commented Dec 24, 2018

@GrahamcOfBorg test gitlab

@flokli flokli merged commit 747fd9f into NixOS:master Dec 25, 2018
@flokli
Copy link
Contributor Author

flokli commented Dec 25, 2018

Backported to 18.09 in 6869be4 and 337687f.

@flokli flokli deleted the gitlab-11.5.5 branch December 25, 2018 14:29
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @samueldr @GrahamcOfBorg