Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSP_VERSION in the GUI #2621

Closed
yalov opened this issue Dec 23, 2018 · 7 comments
Closed

KSP_VERSION in the GUI #2621

yalov opened this issue Dec 23, 2018 · 7 comments
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI Registry Issues affecting the registry Spec Issues affecting the spec

Comments

@yalov
Copy link
Contributor

yalov commented Dec 23, 2018

Active ksp is 1.6.0. Let say we have two mods:

1) ksp_ver: 1.6.0 ksp_min: 1.2.2, ksp_max: 1.9.9
2) ksp_ver: 1.2.2 ksp_min: 1.2.2, ksp_max: 1.9.9

Most likely, the second one was created long time ago, creator thought what it is for any future version, and they haven't touched it since 1.2.2,
but the first one, most likely, was tested for working in 1.6.0.

Good idea to know this info — another column in the Versions tab — "Target KSP Version"

@HebaruSan
Copy link
Member

HebaruSan commented Dec 24, 2018

No such thing in CKAN metadata. ksp_version doesn't co-exist with ksp_version_min or ksp_version_max.

Sorry, something went wrong.

@yalov
Copy link
Contributor Author

yalov commented Dec 24, 2018

What do you mean?
Many .version files have all "KSP_VERSION", "KSP_VERSION_MIN", "KSP_VERSION_MAX"

Sorry, something went wrong.

@HebaruSan
Copy link
Member

KSP-AVC is not the same as CKAN.
KSP-AVC has what you describe (in fact requires it if you want to use min/max and interpret the spec strictly).
CKAN does not.

Sorry, something went wrong.

@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI Core (ckan.dll) Issues affecting the core part of CKAN Spec Issues affecting the spec Registry Issues affecting the registry labels Dec 29, 2018
@HebaruSan
Copy link
Member

https://github.com/KSP-CKAN/CKAN/blob/master/Spec.md#ksp_version_min

ksp_version_min
The minimum version of KSP the mod requires to operate correctly. Same format as ksp_version. It is an error to include both this and the ksp_version field.

ksp_version_max
The maximum version of KSP the mod requires to operate correctly. Same format as ksp_version. It is an error to include both this and the ksp_version field.

@politas
Copy link
Member

politas commented Feb 25, 2019

Several of our sources for version info have this distinction, so it might be good to add it.

@Sinomen
Copy link

Sinomen commented Jan 20, 2021

Recently couple of mods having "KSP_VERSION" have been updated their CKAN info to "KSP_VERSION_MIN" and "KSP_VERSION_MAX" instead, I'd think this issue is related.

Suggestion: for mods having"KSP_VERSION", automatically replace that with "KSP_VERSION_MIN" and "KSP_VERSION_MAX" with identical version number as per "KSP_VERSION", unifying these meta data.

Example: https://github.com/KSP-CKAN/CKAN-meta/pull/2238/files

@HebaruSan
Copy link
Member

As noted, this request does not reflect how CKAN metadata works. Making it work this way would make things much more confusing. Closing.

@HebaruSan HebaruSan closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI Registry Issues affecting the registry Spec Issues affecting the spec
Projects
None yet
Development

No branches or pull requests

4 participants