Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datadog-agent: 6.4.2 -> 6.8.3 #52765

Merged
merged 1 commit into from Jan 8, 2019
Merged

datadog-agent: 6.4.2 -> 6.8.3 #52765

merged 1 commit into from Jan 8, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Dec 24, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

memberbetty
memberbetty approved these changes Dec 24, 2018
View reviewed changes
Copy link
Contributor

@memberbetty memberbetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see this in 18.09 too.

@infinisil
Copy link
Member

@GrahamcOfBorg build datadog-agent

@infinisil
Copy link
Member

Does the package work @Izorkin? It would be good to have even a little sentence in your PR description on what you tested.

@Izorkin
Copy link
Contributor Author

Izorkin commented Dec 31, 2018

In linux kernel 4.14 datadog v6.4.2 and v6.8.2 normal work.
In linux kernel 4.19 datadog v6.4.2 and v6.8.2 - error running check disk - DataDog/datadog-agent#2822

@Izorkin
Copy link
Contributor Author

Izorkin commented Jan 1, 2019

Fixed check disk in this PR #53141

@Izorkin Izorkin changed the title datadog-agent: 6.4.2 -> 6.8.2 datadog-agent: 6.4.2 -> 6.8.3 Jan 7, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Jan 7, 2019

Update to 6.8.3

infinisil
infinisil reviewed Jan 8, 2019
View reviewed changes
nixos/modules/services/monitoring/datadog-agent.nix Outdated
@@ -186,7 +186,7 @@ in {
type = types.attrs;
default = {
init_config = {};
instances = [ { use-mount = "no"; } ];
instances = [ { use-mount = "false"; } ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this change for? Was the old value invalid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter found in example config https://github.com/DataDog/datadog-agent/blob/master/cmd/agent/dist/conf.d/disk.d/conf.yaml.default#L6

@infinisil infinisil merged commit 6a942ae into NixOS:master Jan 8, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Jan 8, 2019

Thanks!

@Izorkin Izorkin deleted the datadog-agent branch January 8, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil left review comments

@memberbetty memberbetty memberbetty approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @infinisil @memberbetty @GrahamcOfBorg