Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musescore: 2.3.2 -> 3.0 #52835

Merged
merged 2 commits into from Jan 5, 2019
Merged

musescore: 2.3.2 -> 3.0 #52835

merged 2 commits into from Jan 5, 2019

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Dec 25, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@suhr
Copy link
Contributor Author

suhr commented Dec 25, 2018

@vandenoever

@worldofpeace
Copy link
Contributor

@suhr You forgot to change the sha256.

This value can easily be retrieved by replacing it with a false hash like

0000000000000000000000000000000000000000000000000000

and then getting the correct hash from the output in your terminal when you build this.

@worldofpeace
Copy link
Contributor

Link To Release Notes
For those interested

@suhr
Copy link
Contributor Author

suhr commented Dec 26, 2018

r?

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build musescore

@suhr
Copy link
Contributor Author

suhr commented Dec 28, 2018

Is it ok to merge?

@worldofpeace
Copy link
Contributor

Currently fails to build https://logs.nix.ci/?key=nixos/nixpkgs.52835&attempt_id=043dab25-345b-4cce-af09-58caa5f2491f

Needs investigation.

Since version 3.0 it builds with QtWebEngine by default.
@veprbl veprbl mentioned this pull request Jan 5, 2019
69 tasks
@veprbl
Copy link
Member

veprbl commented Jan 5, 2019

@GrahamcOfBorg build musescore

@veprbl veprbl merged commit fb185ff into NixOS:master Jan 5, 2019
@worldofpeace
Copy link
Contributor

Thanks @veprbl for fixing the build ✨

@suhr suhr deleted the musescore branch January 5, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants