Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: 3.0.5 -> 4.0.0 #52770

Merged
merged 1 commit into from Jan 4, 2019
Merged

electron: 3.0.5 -> 4.0.0 #52770

merged 1 commit into from Jan 4, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Dec 24, 2018

Motivation for this change

Include libuuid for libuuid.so.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu eadwu force-pushed the electron/4.0.0 branch 2 times, most recently from 117c9e5 to 544edc7 Compare December 24, 2018 15:56
@joachifm
Copy link
Contributor

joachifm commented Jan 2, 2019

@GrahamcOfBorg build electron

@joachifm joachifm merged commit f0e28f9 into NixOS:master Jan 4, 2019
@eadwu eadwu deleted the electron/4.0.0 branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants