Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minishift: 1.27.0 -> 1.29.0 #52761

Merged
merged 1 commit into from Dec 26, 2018
Merged

minishift: 1.27.0 -> 1.29.0 #52761

merged 1 commit into from Dec 26, 2018

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Dec 24, 2018 •
edited

Motivation for this change

Bump minishift to latest release 馃懠

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vdemeester
minishift: 1.27.0 -> 1.29.0
df15c08 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
nlewo
nlewo approved these changes Dec 26, 2018
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrahamcOfBorg build minishift

@nlewo nlewo merged commit 1223d9f into NixOS:master Dec 26, 2018
@vdemeester vdemeester deleted the update-minishift branch December 26, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vdemeester @nlewo @GrahamcOfBorg