Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even numbered versions for releases #2615

Closed
yalov opened this issue Dec 17, 2018 · 10 comments
Closed

Even numbered versions for releases #2615

yalov opened this issue Dec 17, 2018 · 10 comments

Comments

@yalov
Copy link
Contributor

yalov commented Dec 17, 2018

I am using a compiled 1.25.5 version, but when the real 1.25.5 version will be released, I will not be able to update with the built-in updater, I will need to manually download it. Same was happening before with the updating 1.25.4 compiled version.

Updating a version just before a release or switching to an even-release will fix that.
1.25.4 (release) → 1.25.5 (developing) → 1.25.6 (release) → ...

@yalov yalov changed the title Switching to a new version just before release Even numbered versions for releases Dec 21, 2018
@Ruedii
Copy link

Ruedii commented Dec 27, 2018

Another option is to use of a date substring at the end of releases and dev builds, or you could simply use alphabetical sub-string tags such as "Alpha, "Beta", "RC", "Release"

This would also solve the problem.

Sorry, something went wrong.

@HebaruSan
Copy link
Member

They're not alphas, betas, or release candidates, though. They're just somebody's random compile.

Sorry, something went wrong.

@HebaruSan
Copy link
Member

On balance I think changing this would make things worse. I don't want my custom compiled copy in ~/github/CKAN/_build/ckan.exe to be overwritten by a download from the internet.

Sorry, something went wrong.

@yalov
Copy link
Contributor Author

yalov commented Jan 10, 2019

Do you have some secret version of the CKAN ? :)
Then just don't update it, when it will say what there is a new version.
But a casual comrade developer, that has some randomly compiled version, want to have notification, which will suggest him to update to the last official release when it will be released

@politas
Copy link
Member

politas commented Jan 14, 2019

If you are running a release, it will auto-update when a new release comes out. It you are compiling it, you are bypassing the release mechanism, and will need to keep compiling it. How is this confusing?

@yalov
Copy link
Contributor Author

yalov commented Jan 19, 2019

If you are compiling it, you are bypassing the release mechanism

I am not, compiled version is in between of 2 releases.

@DasSkelett
Copy link
Member

DasSkelett commented Jan 19, 2019

So it's not a release, is it?

But I could imagine an indication for non-releases, combined with no automatic, but possible manual updating.

@yalov
Copy link
Contributor Author

yalov commented Jan 19, 2019

Compiled version is not a release.

There is a CKAN option on the settings — "check for SCAN updates". And the button for checking updates.
if user don't want updates, whatever they has compiled in between or released version, they just disable automatic updates, and don't click the button.
if user want to update, they expect to click the button or enable checkbox and get an update.

Released version is an update for every compiled in between version, is it?

@DasSkelett
Copy link
Member

DasSkelett commented Jan 19, 2019

So my suggestion would just need a ".<buildNumber>" or similar (kinda like @Ruedii proposed) added to the version string (edit: in the CLI we have it already, we would just need to use it in the update process...)
Deselect searching for updates if you want (like you can already).
And if you keep it selected, it just behaves like normal release versions.

This would solve @yalov's issue, and @HebaruSan could keep the custom builds.

@politas
Copy link
Member

politas commented Feb 25, 2019

It is certainly possible to use a different number in between releases to what is used for the release itself. It just means updating the version number in CHANGELOG.md as part of the release process. The only people this affects are those that occasionally compile CKAN and want to then automatically get the release when it drops.

Process updated here

@politas politas closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants