Skip to content

all-packages.nix: remove obsolete comments #52949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2018
Merged

all-packages.nix: remove obsolete comments #52949

merged 1 commit into from
Dec 27, 2018
+0 −6

Conversation

ivan
Copy link
Member

@ivan ivan commented Dec 27, 2018

Motivation for this change

Remove copy-pasted comment for these newer kernels because cgroup2 cpu controller support was merged into Linux 4.15 in torvalds/linux@22714a2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ivan
all-packages.nix: remove obsolete comments

Verified

This commit was signed with the committer’s verified signature.
samueljsb Samuel Searles-Bryant
SSH Key Fingerprint: UG1vbpwfv/yF8hRSqV7FLQGL2iSyjGsdQ/WDrm5be+I
Verified
Learn about vigilant mode
78c56d7 
cgroup2 cpu controller support was merged into Linux 4.15:
torvalds/linux@22714a2
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 27, 2018
@worldofpeace worldofpeace merged commit 3ccb95e into NixOS:master Dec 27, 2018
@worldofpeace
Copy link
Contributor

@ivan Thanks. I was wondering if that comment wasn't valid anymore, and it turned out it wasn't 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan @worldofpeace @GrahamcOfBorg