Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby_2_6: init at 2.6.0 #52860

Merged
merged 1 commit into from Dec 26, 2018
Merged

ruby_2_6: init at 2.6.0 #52860

merged 1 commit into from Dec 26, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 25, 2018

Motivation for this change

https://www.ruby-lang.org/en/news/2018/12/25/ruby-2-6-0-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

alyssais
alyssais reviewed Dec 26, 2018
View reviewed changes
pkgs/development/interpreters/ruby/patchsets.nix
@@ -16,4 +16,6 @@ rec {
"${patchSet}/patches/ruby/2.5/head/railsexpress/02-improve-gc-stats.patch"
"${patchSet}/patches/ruby/2.5/head/railsexpress/03-more-detailed-stacktrace.patch"
];
"2.6.0" = ops useRailsExpress [
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this is here because Rails express patches aren’t available yet? If that’s the case, could we have a comment to that effect explaining the empty code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment
FWIW I'm testing ruby 2.6 with a mid-size rails application and I haven't found any downside

@alyssais alyssais merged commit 626cc7e into NixOS:master Dec 26, 2018
@marsam marsam deleted the init-ruby-26 branch December 26, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @alyssais @GrahamcOfBorg