Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qbittorrent: 4.1.4 -> 4.1.5 #52895

Merged
merged 1 commit into from Dec 27, 2018
Merged

qbittorrent: 4.1.4 -> 4.1.5 #52895

merged 1 commit into from Dec 27, 2018

Conversation

ivan
Copy link
Member

@ivan ivan commented Dec 26, 2018 •
edited

Motivation for this change

Bugfix release with mostly webui changes: https://www.qbittorrent.org/news.php

qbittorrent/qBittorrent@release-4.1.4...release-4.1.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It seems to be running fine here.

@FRidh
Copy link
Member

FRidh commented Dec 26, 2018

@GrahamcOfBorg eval

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build qbittorrent

@worldofpeace worldofpeace merged commit 984c843 into NixOS:master Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ivan @FRidh @worldofpeace @GrahamcOfBorg