Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elixir_1_8: init at 1.8.0-rc.1 #52932

Merged
merged 3 commits into from Jan 5, 2019
Merged

elixir_1_8: init at 1.8.0-rc.1 #52932

merged 3 commits into from Jan 5, 2019

Conversation

ejpcmac
Copy link
Contributor

@ejpcmac ejpcmac commented Dec 26, 2018

Motivation for this change

A new Elixir minor version is available in release candidate. I’ve added it as an option for those who want to start using it early, however elixir_1_7 remains the current default.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ejpcmac ejpcmac changed the title elixir_1_8: init at 1.8.0-rc.0 elixir_1_8: init at 1.8.0-rc.1 Jan 3, 2019
@ejpcmac
Copy link
Contributor Author

ejpcmac commented Jan 3, 2019

I just updated it to 1.8.0-rc.1.

@@ -7697,7 +7697,7 @@ in
inherit (beam.interpreters)
erlang erlangR18 erlangR19 erlangR20 erlangR21
erlang_odbc erlang_javac erlang_odbc_javac erlang_nox erlang_basho_R16B02
elixir elixir_1_7 elixir_1_6 elixir_1_5 elixir_1_4 elixir_1_3
elixir elixir_1_8 elixir_1_7 elixir_1_6 elixir_1_5 elixir_1_4 elixir_1_3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove some older ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the official documentation, Elixir 1.3 is indeed not supported anymore. I’ll push a new commit to drop support in nixpkgs tonight.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 I forgot to do it yesterday evening, but now it is done.

@Mic92 Mic92 merged commit 8832292 into NixOS:master Jan 5, 2019
@ejpcmac ejpcmac deleted the init-elixir_1_8 branch January 5, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants