pythonPackages.pdf2image: 1.0.0 -> 1.3.1 #52951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1.3.1 is out. |
Gerschtli
force-pushed
the
update/pdf2image
branch
from
7e99b3f
to
9431708
Compare
Gerschtli
changed the title
|
@GrahamcOfBorg build pythonPackages.pdf2image python3Packages.pdf2image |
worldofpeace
reviewed
Jan 4, 2019
| @@ -2,13 +2,13 @@ | |||
|
|
|||
| buildPythonPackage rec { | |||
| pname = "pdf2image"; | |||
| version = "1.0.0"; | |||
| version = "1.3.1"; | |||
|
|
|||
| buildInputs = [ pillow poppler_utils ]; | |||
There was a problem hiding this comment.
pillow should be a propagatedBuildInputs https://github.com/Belval/pdf2image/blob/8cf6e7773359521c07a82cee786532d918273b2e/setup.py#L48
Not sure about poppler_utils though.
|
Yeah seems about right. I'm always struggling with the difference of these two. Do you mind explaining it to me? |
|
I think for python it documented under "9.11.1.2.2. Handling dependencies" in the nixpkgs manual. |
Gerschtli
force-pushed
the
update/pdf2image
branch
from
9431708
to
f94016e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update package.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)