sd-image-aarch64: use default (LTS) kernel #52886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This, paired with the previous commit, ensures the channel won't be held back from a kernel upgrade and a non-building sd image, while still having a new-kernel variant available.
samueldr
force-pushed
the
aarch64/sd-image-kernel-version
branch
from
2368ef7
to
387098c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A follow-up to #52863 and #52721 (comment).
With this merged, please only paired with #52863 (so no sd-image with a regressed kernel gets built), this will fix the current issue holding back channel updates.
This uses the same kernel as it does for
iso-image, the default kernel, usually the most recent LTS. This also adds a new attribute onrelease.nixsd_image_new_kernelwhich is likeiso_minimal_new_kernel.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)Do note that
sd_image_new_kernelcurrently doesn't build, for the same reasonsd_imagecurrently doesn't. When thezfsissues for Linux 4.20 will be fixed, it should be fixed as well.