Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrow-cpp: fix build #52934

Merged
merged 1 commit into from Dec 26, 2018
Merged

arrow-cpp: fix build #52934

merged 1 commit into from Dec 26, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 26, 2018 •
edited

Fixes: 1f6b095 ('gtest: build shared library')
Closes: #52928

Motivation for this change

arrow-cpp is broken

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
arrow-cpp: fix build
956b4a8 
Fixes: 1f6b095 ('gtest: build shared library')
@veprbl
Copy link
Member Author

veprbl commented Dec 26, 2018

cc @orivej @jtojnar for review

@veprbl veprbl merged commit 8e79ebc into NixOS:master Dec 26, 2018
@veprbl veprbl deleted the pr/arrow_cpp_gtest_fix branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@veprbl @orivej @jtojnar @GrahamcOfBorg