Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

granite: 5.2.1 -> 5.2.2 #52954

Merged
merged 2 commits into from Dec 27, 2018
Merged

granite: 5.2.1 -> 5.2.2 #52954

merged 2 commits into from Dec 27, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Closes #52882

Usual update but with stuff that I've already done to granite in #48637 that should be on master.
Most importantly this should fix certain elementary third-party applications from breaking.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg build regextester notejot taxi hashit spice-up bookworm tootle transporter aesop deepin-wm vocal quilter nasc sequeler

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg build deepin.deepin-wm

@worldofpeace
granite: various cleanups
ea33121 
This is just stuff that's in NixOS#48637 already that I wanted to sync.

In detail it's:

  - Patching in the use of meson

  - Add wrapGAppsHook and hicolor-icon-theme
    There's a demo application and granite
     provides some generic icons.

  - Included patches so third party apps still work
@worldofpeace
Copy link
Contributor Author

Thanks @jtojnar

@worldofpeace worldofpeace merged commit f3d4c91 into NixOS:master Dec 27, 2018
@worldofpeace worldofpeace deleted the granite/5.2.2 branch December 27, 2018 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jtojnar @GrahamcOfBorg