Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gping: init at 1.1 #52864

Merged
merged 1 commit into from Feb 7, 2019
Merged

gping: init at 1.1 #52864

merged 1 commit into from Feb 7, 2019

Conversation

andrew-d
Copy link
Contributor

Motivation for this change

gping is a utility to display a graph of ping timing in a terminal. It looks like this:
screencast

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nlewo
nlewo requested changes Jan 1, 2019
View reviewed changes
pkgs/tools/networking/gping/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/gping/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/gping/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/gping/default.nix Outdated Show resolved Hide resolved
nlewo
nlewo reviewed Jan 3, 2019
View reviewed changes
pkgs/tools/networking/gping/default.nix Outdated
@@ -0,0 +1,25 @@
{ stdenv
, lib

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this blankline is usefull

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@andrew-d
gping: init at 1.1
855d370 
gping is a utility to display a graph of ping timing in a terminal
@andrew-d
Copy link
Contributor Author

andrew-d commented Jan 4, 2019

@nlewo - Okay, fixed the blank line. I also updated to use Python 3, since it uses subprocess.getoutput in one place, which is only available in Python 3. And finally, I patched the path to the ping binary. This means it won't pick up the setuid wrapper under /run/wrappers/bin, but I like this approach better (and one can always add a wrapper for the gping binary).

@andrew-d
Copy link
Contributor Author

andrew-d commented Feb 4, 2019

@nlewo - Anything else you'd like me to do in this PR?

@nlewo
Copy link
Member

nlewo commented Feb 7, 2019

@andrew-d no, that's fine. Thx!
@GrahamcOfBorg build gping

@nlewo
Copy link
Member

nlewo commented Feb 7, 2019

Thx!

@nlewo nlewo merged commit bcd199c into NixOS:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrew-d @nlewo @GrahamcOfBorg