Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luakit: add HTTPS support #52865

Merged
merged 2 commits into from Dec 30, 2018
Merged

luakit: add HTTPS support #52865

merged 2 commits into from Dec 30, 2018

Conversation

emmanuelrosa
Copy link
Contributor

@emmanuelrosa emmanuelrosa commented Dec 25, 2018 •
edited

Motivation for this change

The current luakit package doesn't include glib-networking as a dependency. Thus when accessing HTTPS sites luakit blocks the site, claiming it's untrusted.

This change adds glib-networking so that luakit supports HTTPS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • [ ] macOS
    • other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after): previous package 968318936, new package 1068268984
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace @emmanuelrosa
Update pkgs/applications/networking/browsers/luakit/default.nix
8d7b4bd 
Co-Authored-By: emmanuelrosa <emmanuelrosa@users.noreply.github.com>
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build luakit

worldofpeace
worldofpeace approved these changes Dec 30, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test but it sounds good, I've ran into this issue a few times as well.

@worldofpeace worldofpeace merged commit 421dd51 into NixOS:master Dec 30, 2018
@emmanuelrosa emmanuelrosa deleted the luakit-glib-networking branch December 30, 2018 14:41
@jtojnar jtojnar mentioned this pull request Feb 24, 2019
Closed
vcunat pushed a commit that referenced this pull request Feb 24, 2019
@emmanuelrosa @vcunat
luakit: add HTTPS support (#52865)
2354875 
Co-Authored-By: emmanuelrosa <emmanuelrosa@users.noreply.github.com>
(cherry picked from commit 421dd51)
Fixes #56266.  I briefly re-tested that on 18.09.
@spiderbit
Copy link

Stupid question is that in the unstable branch?

I added that but did not help so far:

    (let newpkgs = import (fetchTarball https://github.com/NixOS/nixpkgs-channels/archive/nixos-unstable.tar.gz) {};
    in
      newpkgs.luakit
    )

@vcunat
Copy link
Member

vcunat commented Feb 24, 2019

Yes, it is. I re-tested this simple pair of commands

$ nix build -f https://github.com/NixOS/nixpkgs-channels/archive/nixos-unstable.tar.gz luakit
$ ./result/bin/luakit https://nixos.org

@spiderbit
Copy link

Sorry I am stupid I had a instance of luakit open in the background so it only opened a new window not start the new binary :D works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emmanuelrosa @worldofpeace @spiderbit @vcunat @GrahamcOfBorg