Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looking-glass-client: a11 -> a12 #52905

Merged
merged 1 commit into from Dec 29, 2018
Merged

Conversation

jchv
Copy link
Contributor

@jchv jchv commented Dec 26, 2018

Motivation for this change

There was a new upstream release. (A very good one, too.)

Looking Glass a12 now uses cmake, so aside from updating the hashes I had to adjust a couple other things.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

(I'm very new to Nix, sorry if I've not done this correctly.)

@timokau
Copy link
Member

timokau commented Dec 29, 2018

@GrahamcOfBorg build looking-glass-client

@timokau
Copy link
Member

timokau commented Dec 29, 2018

Looks good to me! Thanks an congrats on your first contribution :)

@timokau timokau merged commit 79f76b8 into NixOS:master Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants