-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/amazon-init: add ec2.userData option to copy config only once (closes #41826) #52945
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nonce file location should be below some nix hierarchy. I.e. a descendant of /nix
or /etc/nixos
to reduce clashing with third party software that would also use /root/.initialized
.
Additionally the nonce file should have some text that points at this code with the reason described in the file.
Done. I decided to put it under /etc/nixos so it's trivial to put there from the configuration via environment.etc. |
8a4bb69
to
1b3817a
Compare
d4ca55c
to
ddda338
Compare
Updated to use an option in addition to a nonce file, which seemed like a cleaner solution to me and also allows the use case of #66487. |
This option prevents NixOS from copying invalid or outdated configurations from EC2 user data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good option to have. Suspect if we clean up conflicts this can be merged.
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly:
|
This is still something I’d love to see! |
I marked this as stale due to inactivity. → More info |
Motivation for this change
see #41826.
This is also important when the contents are not a valid NixOS configuration and cannot be controlled, as is the case on, for example, Amazon Lightsail.
Things done
sandbox
innix.conf
on non-NixOS)Nope, test seems to be broken already??
nix path-info -S
before and after)